[Mesa-dev] [PATCH] glsl: Fix absurd whitespace conventions in the parser.

Matt Turner mattst88 at gmail.com
Sat Jul 13 15:00:44 PDT 2013


On Sat, Jul 13, 2013 at 2:58 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> Historically, we indented grammar production rules with a single 8-space
> tab, but code inside of blocks used Mesa's 3-space indents.
>
> This meant when editing code, you had to use an 8-space tab for the
> first level of indentation, and 3-spaces after that.  Unless you
> specifically configure your editor to understand this, it will get the
> indentation wrong on every single line you touch, which quickly devolves
> into a colossal waste of time.
>
> It's also inconsistent with every other file in the entire project.
>
> This patch removes all tabs and moves to a consistent 3-space indent.

Yes please!

Reviewed-by: Matt Turner <mattst88 at gmail.com>


More information about the mesa-dev mailing list