[Mesa-dev] [PATCH 00/14] Qualifier ordering for 420pack

[Matt Turner]

On Mon, Jul 15, 2013 at 7:32 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> Hello!
>
> The GL_ARB_shading_language_420pack allows qualifiers to be specified in
> a flexible order, which is nice now that there are so many different
> qualifiers.  Yet, we still need to support the old language semantics
> which enforce a particular ordering as well.
>
> Previously, we handled the ordering requirements using the GLSL 1.50
> grammar rules.  This obviously can't handle the flexible ordering, so
> so I had to rewrite the grammar to allow qualifiers in any order, then
> add C code to enforce the pre-4.20 ordering restrictions.
>
> No regressions observed on Piglit or ES3, though we need a bunch more
> tests.  A few extra are in the 'qualifiers' branch of ~kwg/piglit, though
> I believe Matt is writing more.
>
> I'm hoping to land this before Thursday.  With one more tiny feature,
> we can enable 420pack for 9.2...
>
> Please review...sooner rather than later :)
>
> The series is available as the 'qualifiers' branch of ~kwg/mesa; if
> applying from the mailing list, apply these first:
>
> glsl: Silence the last shift/reduce conflict warning in the grammar.
> glsl: Fail the build if the grammar contains shift/reduce errors.
> glsl: Fix absurd whitespace conventions in the parser.

The series is

Reviewed-by: Matt Turner <mattst88 at gmail.com>

with the two fixes folded in. The duplicate layout qualifier change
should probably go in a different patch from the one I commented on.

Piglit tests are on the list, and after reviewing your series I see
some other things I should test.

Thanks!

Matt