[Mesa-dev] [PATCH 11/11] i965: Enable the GL_ARB_shading_language_420pack extension.

[Paul Berry]

On 17 July 2013 18:24, Kenneth Graunke <kenneth at whitecape.org> wrote:

> Everything is done.  Every driver that supports 1.30 should enable this
> extension.
>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
>

I've made comments on patches 3 and 5.

We talked in person about clarifying the commit messages in patches 1 and
7.  I don't think those clarifications are critical, so in any case those
two patches get my reviewed-by.

I don't feel qualified to review patches 8 and 10--they touch code in
sampler and UBO land that I'm not sufficiently familiar with.  I'm happy to
give them an acked-by, though.

The remainder (patches 2, 4, 6, 9, and 11) look great, and are:

Reviewed-by: Paul Berry <stereotype441 at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130718/cd969bf7/attachment.html>