[Mesa-dev] [PATCH 10/15] st/dri: remove driOptionCache from dri_context in favor of dri_screen

Marek Olšák maraeo at gmail.com
Fri Jul 19 08:18:20 PDT 2013


There is no reason to have this duplicated.
---
 src/gallium/state_trackers/dri/common/dri_context.c | 12 +-----------
 src/gallium/state_trackers/dri/common/dri_context.h |  2 --
 2 files changed, 1 insertion(+), 13 deletions(-)

diff --git a/src/gallium/state_trackers/dri/common/dri_context.c b/src/gallium/state_trackers/dri/common/dri_context.c
index 6603491..b5445f8 100644
--- a/src/gallium/state_trackers/dri/common/dri_context.c
+++ b/src/gallium/state_trackers/dri/common/dri_context.c
@@ -109,11 +109,7 @@ dri_create_context(gl_api api, const struct gl_config * visual,
    ctx->cPriv = cPriv;
    ctx->sPriv = sPriv;
 
-   driParseConfigFiles(&ctx->optionCache,
-		       &screen->optionCacheDefaults,
-                       sPriv->myNum, driver_descriptor.name);
-
-   dri_fill_st_options(&attribs.options, &ctx->optionCache);
+   dri_fill_st_options(&attribs.options, &screen->optionCache);
    dri_fill_st_visual(&attribs.visual, screen, visual);
    ctx->st = stapi->create_context(stapi, &screen->base, &attribs, &ctx_err,
 				   st_share);
@@ -171,12 +167,6 @@ dri_destroy_context(__DRIcontext * cPriv)
       hud_destroy(ctx->hud);
    }
 
-   /* note: we are freeing values and nothing more because
-    * driParseConfigFiles allocated values only - the rest
-    * is owned by screen optionCacheDefaults.
-    */
-   free(ctx->optionCache.values);
-
    /* No particular reason to wait for command completion before
     * destroying a context, but we flush the context here
     * to avoid having to add code elsewhere to cope with flushing a
diff --git a/src/gallium/state_trackers/dri/common/dri_context.h b/src/gallium/state_trackers/dri/common/dri_context.h
index 2734ee5..b87ce40 100644
--- a/src/gallium/state_trackers/dri/common/dri_context.h
+++ b/src/gallium/state_trackers/dri/common/dri_context.h
@@ -50,8 +50,6 @@ struct dri_context
    __DRIdrawable *dPriv;
    __DRIdrawable *rPriv;
 
-   driOptionCache optionCache;
-
    unsigned int bind_count;
 
    /* gallium */
-- 
1.8.1.2



More information about the mesa-dev mailing list