[Mesa-dev] [PATCH mesa 1/3] gallium-egl: Simplify native_wayland_drm_bufmgr_helper interface

[Emil Velikov]

On 19/07/13 09:17, Ander Conselvan de Oliveira wrote:
> On 07/18/2013 10:04 PM, Emil Velikov wrote:
>> On 18/07/13 13:11, Ander Conselvan de Oliveira wrote:
> 
> [...]
> 
>>> +static EGLBoolean
>>> +wayland_drm_bufmgr_query_buffer(struct native_display *ndpy,
>>> +                                struct wl_buffer *_buffer,
>>> +                                EGLint attribute, EGLint *value)
>>
>> According to
>> src/gallium/state_trackers/egl/common/native_wayland_bufmgr.h the
>> function should use non EGL variable types
>>
>>     boolean (*query_buffer)(struct native_display *ndpy,
>>                             struct wl_buffer *buffer,
>>                             int attribute, int *value);
>>
>> otherwise the compiler complains a bit :\
> 
> The problem was already there before the change. I don't know if there
> is some issue with including EGL types in the native_wayland_bufmgr.h,
> but I just sent a patch to fix this.
> 
True, the original code did have the exact same "missmatch". I recall
sending a patch addressing it, although it got lost somewhere :]

Btw, I'm not sure if any many people are using Android or scons to build
this code, but either way your patches seems to have missed them
unfortunately.

Thanks again for the patches

Cheers
Emil