[Mesa-dev] [PATCH 1/2] mesa: Return GL_FRAMEBUFFER_UNDEFINED if the winsys fbo is incomplete.

[Kenneth Graunke]

On 07/26/2013 04:36 PM, Matt Turner wrote:
> Specified by ARB_framebuffer_object, GL 3.0, and ES 3.0.
> ---
>   src/mesa/main/fbobject.c | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
> index a29f1ab..bf7e85c 100644
> --- a/src/mesa/main/fbobject.c
> +++ b/src/mesa/main/fbobject.c
> @@ -2141,8 +2141,12 @@ _mesa_CheckFramebufferStatus(GLenum target)
>      }
>
>      if (_mesa_is_winsys_fbo(buffer)) {
> -      /* The window system / default framebuffer is always complete */
> -      return GL_FRAMEBUFFER_COMPLETE_EXT;
> +      /* EGL_KHR_surfaceless_context allows the winsys FBO to be incomplete. */
> +      if (buffer != &IncompleteFramebuffer) {
> +         return GL_FRAMEBUFFER_COMPLETE_EXT;
> +      } else {
> +         return GL_FRAMEBUFFER_UNDEFINED;
> +      }
>      }
>
>      /* No need to flush here */
>

Looks right to me...

Both patches are:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>