[Mesa-dev] [PATCH] glsl: Remove shader stage checking for extension handling.

Kenneth Graunke kenneth at whitecape.org
Mon Jul 29 14:06:59 PDT 2013


On 07/29/2013 10:55 AM, Kenneth Graunke wrote:
> Certain extensions only add functionality to particular shader stages.
> (For example, ARB_draw_instanced only adds variables to the vertex
> shader stage.)
>
> Previously, we only allowed such extensions to be enabled in the shader
> stages where they're useful.  However, I've never found any text which
> mandates that behavior; in my opinion, you should be able to turn on
> extensions in any shader stage, even if they have no effect.
>
> Fixes Piglit tests glslparsertest/glsl2/draw_buffers-05.vert and
> ARB_draw_instanced/preprocessor/feature-macro-enabled.frag.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=29185
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>   src/glsl/glsl_parser_extras.cpp | 89 +++++++++++++----------------------------
>   1 file changed, 28 insertions(+), 61 deletions(-)

Apparently I accidentally pushed this :( Sorry for short-circuiting the 
process.  If people have any concerns, I can revert it.

--Ken


More information about the mesa-dev mailing list