[Mesa-dev] [PATCH 4/4] mesa/program: Switch from the deprecated YYLEX_PARAM to %lex-param.

Kenneth Graunke kenneth at whitecape.org
Mon Jul 29 16:07:38 PDT 2013


YYLEX_PARAM is no longer supported as of Bison 3.0.  Instead, the Bison
developers recommend using %lex-param.

%lex-param takes a type and variable name, similar to %parse-param,
so you can't pass an arbitrary expression like state->scanner.  But Flex
insists on passing the actual scanner object, not an arbitrary object
like state.

To solve this, the parser defines a wrapper lex() function which accepts
"state," and calls Flex's lex() function with state->scanner.

Fixes the build with Bison 3.0.  Also works with Bison 2.7.1.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67354
Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Cc: mesa-stable at lists.freedesktop.org
Cc: Sandeep <sandy.8925 at gmail.com>
Cc: Bruno Jacquet <maxijac at free.fr>
Cc: Laurent Carlier <lordheavym at gmail.com>
Cc: Nikita Malyavin <nikitamalyavin at gmail.com>
---
 src/mesa/program/program_parse.y | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/mesa/program/program_parse.y b/src/mesa/program/program_parse.y
index 6415bef..3aceb21 100644
--- a/src/mesa/program/program_parse.y
+++ b/src/mesa/program/program_parse.y
@@ -113,15 +113,13 @@ static struct asm_instruction *asm_instruction_copy_ctor(
 	    + (Current).first_column;					\
       }									\
    } while(YYID(0))
-
-#define YYLEX_PARAM state->scanner
 %}
 
 %pure-parser
 %locations
+%lex-param   { struct asm_parser_state *state }
 %parse-param { struct asm_parser_state *state }
 %error-verbose
-%lex-param { void *scanner }
 
 %union {
    struct asm_instruction *inst;
@@ -274,9 +272,10 @@ _mesa_program_lexer_lex(YYSTYPE *yylval_param, YYLTYPE *yylloc_param,
                         void *yyscanner);
 
 static int
-yylex(YYSTYPE *yylval_param, YYLTYPE *yylloc_param, void *yyscanner)
+yylex(YYSTYPE *yylval_param, YYLTYPE *yylloc_param,
+      struct asm_parser_state *state)
 {
-   return _mesa_program_lexer_lex(yylval_param, yylloc_param, yyscanner);
+   return _mesa_program_lexer_lex(yylval_param, yylloc_param, state->scanner);
 }
 %}
 
-- 
1.8.3.4



More information about the mesa-dev mailing list