[Mesa-dev] [Mesa-stable] [PATCH] i965/vs: Put lod parameter in the correct place for Gen4

Kenneth Graunke kenneth at whitecape.org
Mon Jul 29 14:57:55 PDT 2013


On 07/29/2013 12:05 PM, Chris Forbes wrote:
> This was never visible before due to the bogus sampler state pointer.
> Fixes remaining vertex texturing breakage on Gen4.
>
> Signed-off-by: Chris Forbes <chrisf at ijw.co.nz>
> Cc: mesa-stable at lists.freedesktop.org
> ---
>   src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> index 1d86b33..5254850 100644
> --- a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> @@ -2427,7 +2427,7 @@ vec4_visitor::visit(ir_texture *ir)
>   	    }
>   	 } else /* brw->gen == 4 */ {
>   	    mrf = param_base;
> -	    writemask = WRITEMASK_Z;
> +	    writemask = WRITEMASK_W;
>   	 }
>   	 emit(MOV(dst_reg(MRF, mrf, lod_type, writemask), lod));
>         } else if (ir->op == ir_txf) {

Yep, definitely should be W.  Thanks for fixing this.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>


More information about the mesa-dev mailing list