[Mesa-dev] [PATCH 06/34] draw/gs: fix allocation of buffer for GS output vertices

[Jose Fonseca]

----- Original Message -----
> On Tue, Jul 30, 2013 at 8:46 PM, Paul Berry <stereotype441 at gmail.com> wrote:
> > On 29 July 2013 11:09, Zack Rusin <zackr at vmware.com> wrote:
> >>
> >> That looks wrong to me. We already account for the "other fields" in the
> >> vertex_size.
> >
> >
> > This patch came from Bryan Cain's original geometry shader patch series--I
> > admit I'm not familiar enough with Gallium code to know how to fix it.
> > Anyone want to step in and address Zack's comment?  Or the Gallium-related
> > comments on patches 08 and 24?
> >
> > If no one has time to work on Gallium geometry shaders right now, that's
> > ok.
> > I can pull the Gallium stuff out of this series and archive it in a branch
> > until someone has time to pick it up.
> 
> This patch is a year old, and I don't remember what it was supposed to
> fix.  The Gallium geometry shader code has changed significantly in
> the last year, and it should be safe to leave this patch unmerged.  If
> any problems come up as a result, they can be addressed then.

draw/gallivm in master already has working geometry shader support (though never tested with Mesa state tracker), so it seems to me that it would be better to just leave out any draw/gallivm changes from this series, and address any inconsistencies afterwards.

Jose