[Mesa-dev] [PATCH 34/34] main: Warn that geometry shader support is experimental.

[Ian Romanick]

On 07/28/2013 11:04 PM, Paul Berry wrote:
> Geometry shader support in the Mesa front end is still fairly
> preliminary.  Many features are untested, and the following things are
> known not to work:
>
> - The gl_in interface block
> - The gl_ClipDistance input
> - Transform feedback of geometry shader outputs
> - Constants that are new in GLSL 1.50 (e.g. gl_MaxGeometryInputComponents)
>
> This isn't a problem, since no back-end drivers currently enable
> geometry shaders.  However, to make sure no one gets the wrong
> impression, emit a nasty warning to let the user know that geometry
> shader support isn't complete.
> ---
>   src/mesa/main/shaderapi.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c
> index 0eb90aa..7240aba 100644
> --- a/src/mesa/main/shaderapi.c
> +++ b/src/mesa/main/shaderapi.c
> @@ -740,6 +740,12 @@ compile_shader(struct gl_context *ctx, GLuint shaderObj)
>      if (!sh)
>         return;
>
> +   /* Geometry shaders are not yet fully supported, so issue a warning message
> +    * if we're compiling one.
> +    */
> +   if (sh->Type == GL_GEOMETRY_SHADER)
> +      printf("WARNING: Geometry shader support is currently experimental.\n");
> +

Use _mesa_warning.

>      options = &ctx->ShaderCompilerOptions[_mesa_shader_type_to_index(sh->Type)];
>
>      /* set default pragma state for shader */
>