[Mesa-dev] [PATCH 07/34] mesa: account for geometry shader texture fetches in update_texture_state

[Paul Berry]

On 31 July 2013 18:07, Ian Romanick <idr at freedesktop.org> wrote:

> Patches 7, 9 (with Ken's suggestions), 10, 12, 13, 14, 15 (with the one
> nit accounted... 18 and perhaps other have the same issue), 17, 18, 19, 20,
> 21, 22, 27, 28, 29 (though my question may affect 29 & 30), 30, 31, 32
> (with minor nits), 33, and 34 (with a minor nit).
>
> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
>

Wow, thanks for all the review!  I'll go through your comments in detail
tomorrow.


>
> I don't feel like I understand 16 very well.  Perhaps we can talk about it
> tomorrow?


Sure, no problem.  To my knowledge, no one else but me has ever touched the
varying packing code, so it's possible that there are some Paulisms in
there that make the code hard to understand for anyone but me :)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130731/9b537cdd/attachment.html>