[Mesa-dev] [PATCH 4/4] intel: Don't try to blorp or blit CopyTexSubImage(1D_ARRAY).

Eric Anholt eric at anholt.net
Mon Jun 3 09:04:23 PDT 2013


Paul Berry <stereotype441 at gmail.com> writes:

> Blorp and the hardware blitter can't be used to implement
> CopyTexSubImage when the image type is 1D_ARRAY, because of a
> coordinate system mismatch (the Y coordinate in the source image is
> supposed to be matched up to the Z coordinate in the destination
> texture).
>
> The hardware blitter path (intel_copy_texsubimage) contained a perf
> debug warning for this case, but it failed to actually fall back.  The
> blorp path didn't even check.
>
> Fixes piglit test "copyteximage 1D_ARRAY".

I have a patch locally that fixed this within blorp, but I think I
actually want to just change the driver interface so that Mesa core
drives multi-slice copyteximages and the driver just gets a layer field
for which one it's supposed to do.  So I'm fine with this patch for the
moment, since it will take a couple of days to do the core change.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130603/78f259eb/attachment.pgp>


More information about the mesa-dev mailing list