[Mesa-dev] [PATCH 03/13] gallium: Introduce 32-bit bytewise format names

Michel Dänzer michel at daenzer.net
Tue Jun 4 03:04:47 PDT 2013


On Die, 2013-06-04 at 10:47 +0100, Richard Sandiford wrote:
> 
> (2) it uses PIPE_FORMAT_INT_* names with the lsb first rather than the
>     mesa-like ones with msb first.  (I'm happy to change the names to
>     something else though.)
> 
> The patch isn't in a submittable state yet.  I just thought it was worth
> posting because the lsb-first names do make the change look a bit more
> obvious/less scary :-)

I can see the appeal of that, but I also see some danger in that naming
scheme: It'll be easy to miss the difference between the two kinds of
formats, e.g. when grepping for B8G8R8A8. That's why I'd prefer making
the difference more explicit in the naming scheme. Sticking to LSB
first, BGRA8888 might already look a little less scary? :)


-- 
Earthling Michel Dänzer           |                   http://www.amd.com
Libre software enthusiast         |          Debian, X and DRI developer


More information about the mesa-dev mailing list