[Mesa-dev] [v6 3/9] intel: replace single region with a vector of regions

Chad Versace chad.versace at linux.intel.com
Tue Jun 4 20:47:48 PDT 2013


On 05/28/2013 02:17 AM, Topi Pohjolainen wrote:
> No functional change in preparation for supporting multiple planes
> per image each having its own region.
>
> v2 (Chad): Clarify how valid regions are detected. Originally I
>             thought one could also support cases where one region
>             is shared between multiple planes. This is not really
>             needed as the dma-buf-importing already introduces
>             duplicate regions with different offsets (where the
>             regions represent the one and same buffer object).
>
>             I also added utility for resolving the number of
>             regions based on the image layout. This is not used
>             yet but will be later in the series.
>
> Signed-off-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
> ---
>   src/mesa/drivers/dri/intel/intel_fbo.c       |  6 +--
>   src/mesa/drivers/dri/intel/intel_regions.h   | 19 +++++++-
>   src/mesa/drivers/dri/intel/intel_screen.c    | 69 ++++++++++++++--------------
>   src/mesa/drivers/dri/intel/intel_tex_image.c |  2 +-
>   4 files changed, 57 insertions(+), 39 deletions(-)

Thanks for adding the helper function. When it comes time to rebase and commit this patch,
please check closely for any new compilation warnings.


More information about the mesa-dev mailing list