[Mesa-dev] [PATCH v2] Renamed functions for file enums.c

[Ian Romanick]

On 06/05/2013 10:55 AM, Alex Deucher wrote:
> On Wed, Jun 5, 2013 at 1:50 PM, Arnas Milaševičius <giant1gf at gmail.com> wrote:
>> Will it be approved or I need to resend this patch with a better commit
>> massage?
>
> Please resend a version 3 with an improved commit message.  It's also
> good to include a small list of changes between versions if you resend
> the patch multiple times.  E.g.,
>
> v1: initial version
> v2: fixed names as per XXX's comments
> v3: improved commit message

See the commit message on c3bb07f for an example.

> Alex
>
>> On Wed, Jun 5, 2013 at 8:47 PM, Arnas Milaševičius <mla at arnas.me> wrote:
>>>
>>> _mesa_lookup_enum_by_nr() -> _mesa_enum_string()
>>> _mesa_lookup_prim_by_nr() -> _mesa_prim_string()
>>> _mesa_lookup_enum_by_name() -> _mesa_enum_value()
>>>
>>>
>>> On Wed, Jun 5, 2013 at 8:20 PM, Eric Anholt <eric at anholt.net> wrote:
>>>>
>>>> Arnas Milasevicius <giant1gf at gmail.com> writes:
>>>>
>>>>> _mesa_prim_nr changed in:
>>>>>
>>>>> src/mesa/main/api_validate.c
>>>>> src/mesa/main/api_validate.c
>>>>> src/mesa/main/enums.h
>>>>> src/mesa/vbo/vbo_exec_draw.c
>>>>> src/mesa/vbo/vbo_save_api.c
>>>>> src/mesa/vbo/vbo_save_loopback.c
>>>>>
>>>>> _mesa_enum_name changed in:
>>>>>
>>>>> src/mesa/main/enums.h
>>>>> src/mesa/main/tests/enum_strings.cpp
>>>>> src/mesa/main/tests/enum_strings.cpp
>>>>>
>>>>> _mesa_enum_nr changed in:
>>>>>
>>>>> Pretty much in these and other files
>>>>
>>>> I would recommend
>>>> http://who-t.blogspot.de/2009/12/on-commit-messages.html for learning
>>>> how to write commit messages.  From this commit message, I don't know
>>>> what the function names changed to, or why they changed.  The list of
>>>> files changed is not interesting to include in a commit message, because
>>>> you go look at the commit to see that.
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>