[Mesa-dev] [PATCH] build: Use PACKAGE_VERSION from autoconf

Kenneth Graunke kenneth at whitecape.org
Wed Jun 5 23:05:39 PDT 2013


On 06/05/2013 02:42 AM, Andreas Boll wrote:
> Both variables had the same value.
>
> Signed-off-by: Andreas Boll <andreas.boll.dev at gmail.com>
> ---
>   Makefile.am       |    1 -
>   docs/devinfo.html |    1 -
>   2 files changed, 2 deletions(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 92b792d..29405a0 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -36,7 +36,6 @@ check-local:
>
>   # Rules for making release tarballs
>
> -PACKAGE_VERSION=9.2.0-devel
>   PACKAGE_DIR = Mesa-$(PACKAGE_VERSION)
>   PACKAGE_NAME = MesaLib-$(PACKAGE_VERSION)
>
> diff --git a/docs/devinfo.html b/docs/devinfo.html
> index f5eb4d4..5aad0fb 100644
> --- a/docs/devinfo.html
> +++ b/docs/devinfo.html
> @@ -196,7 +196,6 @@ branch is relevant.
>   <h3>Verify and update version info</h3>
>
>   <dl>
> -  <dt>Makefile.am</dt>
>     <dt>SConstruct</dt>
>     <dt>Android.common.mk</dt>
>     <dd>PACKAGE_VERSION</dd>
>

Smart!  There's no point in redeclaring what AC_INIT already does for us.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>


More information about the mesa-dev mailing list