[Mesa-dev] [PATCH 5/8] i965: Don't emit PIPELINE_SELECT from BLORP.

[Chris Forbes]

Does that flush still need to happen, if you're no longer emitting
CMD_PIPELINE_SELECT?

On Sun, Jun 9, 2013 at 7:01 AM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> Now that we emit invariant state at startup (and never select the media
> pipeline), the 3D pipeline will always already be selected, even if BLORP
> is the first operation.  So this is unnecessary.
>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/drivers/dri/i965/gen6_blorp.cpp | 18 ------------------
>  1 file changed, 18 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/gen6_blorp.cpp b/src/mesa/drivers/dri/i965/gen6_blorp.cpp
> index c7bb815..6485143 100644
> --- a/src/mesa/drivers/dri/i965/gen6_blorp.cpp
> +++ b/src/mesa/drivers/dri/i965/gen6_blorp.cpp
> @@ -54,26 +54,8 @@ gen6_blorp_emit_batch_head(struct brw_context *brw,
>
>     /* To ensure that the batch contains only the resolve, flush the batch
>      * before beginning and after finishing emitting the resolve packets.
> -    *
> -    * Ideally, we would not need to flush for the resolve op. But, I suspect
> -    * that it's unsafe for CMD_PIPELINE_SELECT to occur multiple times in
> -    * a single batch, and there is no safe way to ensure that other than by
> -    * fencing the resolve with flushes. Ideally, we would just detect if
> -    * a batch is in progress and do the right thing, but that would require
> -    * the ability to *safely* access brw_context::state::dirty::brw
> -    * outside of the brw_upload_state() codepath.
>      */
>     intel_flush(ctx);
> -
> -   /* CMD_PIPELINE_SELECT
> -    *
> -    * Select the 3D pipeline, as opposed to the media pipeline.
> -    */
> -   {
> -      BEGIN_BATCH(1);
> -      OUT_BATCH(brw->CMD_PIPELINE_SELECT << 16);
> -      ADVANCE_BATCH();
> -   }
>  }
>
>
> --
> 1.8.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev