[Mesa-dev] [PATCH] dlist: fix save_SamplerParameteri

Vinson Lee vlee at freedesktop.org
Sun Jun 9 14:04:22 PDT 2013


On Sun, Jun 9, 2013 at 9:03 AM, Brian Paul <brianp at vmware.com> wrote:
> On 06/09/2013 02:17 PM, Chris Forbes wrote:
>>
>> This was building the temporary array to pass to
>> save_SamplerParameteriv, and then not passing it.
>>
>> Signed-off-by: Chris Forbes <chrisf at ijw.co.nz>
>> ---
>>   src/mesa/main/dlist.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c
>> index 8900c89..af2b468 100644
>> --- a/src/mesa/main/dlist.c
>> +++ b/src/mesa/main/dlist.c
>> @@ -7027,7 +7027,7 @@ save_SamplerParameteri(GLuint sampler, GLenum pname,
>> GLint param)
>>      GLint parray[4];
>>      parray[0] = param;
>>      parray[1] = parray[2] = parray[3] = 0;
>> -   save_SamplerParameteriv(sampler, pname, param);
>> +   save_SamplerParameteriv(sampler, pname, parray);
>>   }
>>
>>   static void GLAPIENTRY
>>
>
> D'oh!
>
> Reviewed-by: Brian Paul <brianp at vmware.com>
>
>

Reviewed-by: Vinson Lee <vlee at freedesktop.org>

Thanks for the fix. I pushed this patch.


More information about the mesa-dev mailing list