[Mesa-dev] [PATCH 1/3] glsl: Add a gl_shader_program parameter to _mesa_uniform_{merge, split}_location_offset

Chad Versace chad.versace at linux.intel.com
Tue Jun 11 15:42:02 PDT 2013


On 06/10/2013 10:52 AM, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
>
> This will be used in the next commit.
>
> NOTE: This is a candidate for stable release branches.
>
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
>   src/mesa/main/uniform_query.cpp            | 2 +-
>   src/mesa/main/uniforms.c                   | 2 +-
>   src/mesa/main/uniforms.h                   | 6 ++++--
>   src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +-
>   4 files changed, 7 insertions(+), 5 deletions(-)

Aside from typos and spec discussion in the other review emails,
the code looks good. It causes no regressions on Haswell Android
gles2conform at 64x64 and fixes 3D Bowling.

Reviewed-and-tested-by: Chad Versace <chad.versace at linux.intel.com>



More information about the mesa-dev mailing list