[Mesa-dev] [PATCH v2 00/12] i965/gen7+: Implement fast color clears.

Eric Anholt eric at anholt.net
Tue Jun 11 16:32:57 PDT 2013


Paul Berry <stereotype441 at gmail.com> writes:

> Changes since the previous version:
>
> - Because of objections, I've dropped the patch "intel: Create
>   intel_miptree_get_region() to prepare for fast color clear."
>   Instead of using an accessor function to ensure that appropriate
>   resolves are performed before any access to
>   intel_mipmap_tree::region, I've simply placed the resolves at the
>   points where they are needed, as we do for HiZ.
>
> - Rebased on top of Eric's intel_miptree_blit code--this reduced the
>   number of places where resolves had to be performed.
>
> - Added a perf_debug message if the client tries to clear to a color
>   that isn't compatible with the fast color clear mechanism.
>
> - Ensured that BRW_NEW_SURFACES is flagged when a fast clear occurs,
>   so that the MCS buffer pointer and the fast clear color will be
>   properly delievered next time the surface is used.
>
> - Fixed some build warnings.
>
> - Added patch 01/12, which avoids a corner case bug that was present
>   in the previous series.

Other than the significant question I had on patch 6/12 about miptree
sizing,

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130611/cae509c2/attachment.pgp>


More information about the mesa-dev mailing list