[Mesa-dev] [PATCH 7/8] util: Expand the comment above the channel[] array

Richard Sandiford rsandifo at linux.vnet.ibm.com
Fri Jun 14 03:48:58 PDT 2013


Will Schmidt <will_schmidt at vnet.ibm.com> writes:
> On Thu, 2013-06-13 at 14:50 +0100, Richard Sandiford wrote:
>>
>
> The entirety of the comment looks pretty good to me.  :-)     One
> question, and this is mostly curiosity on my part, I'm not specifically
> asking for another revision. 
>
>>     * (This is the same as C bitfield layout on most ABIs.)
>
> Do we have a handle on what 'most ABIs' are?   I.e. would this include
> X86* and PPC* ABIs as we know them today, or do we already clearly
> understand which ones would not match?

I think it includes all ABIs supported by GCC, including the various x86
and ppc ones like you say.  I should probably have dropped the bitfield
thing altogether though.

Thanks,
Richard



More information about the mesa-dev mailing list