[Mesa-dev] [PATCH 02/11] mesa: Remove the Initialized field from framebuffers.

[Brian Paul]

On 06/21/2013 12:07 AM, Eric Anholt wrote:
> This existed to tell the core not to call GetBufferSize, except that even
> if you didn't set it nothing happened because nobody had a GetBufferSize.
> ---
>   src/mesa/drivers/dri/intel/intel_fbo.c      | 2 --
>   src/mesa/drivers/dri/radeon/radeon_common.c | 2 --
>   src/mesa/drivers/dri/radeon/radeon_fbo.c    | 2 --
>   src/mesa/main/mtypes.h                      | 2 --
>   src/mesa/state_tracker/st_manager.c         | 2 --
>   5 files changed, 10 deletions(-)
>

You missed a couple other occurrences of this field:


diff --git a/src/mesa/drivers/osmesa/osmesa.c 
b/src/mesa/drivers/osmesa/osmesa.c
index 241e74f..deb0b93 100644
--- a/src/mesa/drivers/osmesa/osmesa.c
+++ b/src/mesa/drivers/osmesa/osmesa.c
@@ -916,7 +916,6 @@ OSMesaMakeCurrent( OSMesaContext osmesa, void 
*buffer, GLenu
      * osmesa_renderbuffer_storage() function to get called.
      */
     _mesa_resize_framebuffer(&osmesa->mesa, osmesa->gl_buffer, width, 
height);
-   osmesa->gl_buffer->Initialized = GL_TRUE; /* XXX TEMPORARY? */

     _mesa_make_current( &osmesa->mesa, osmesa->gl_buffer, 
osmesa->gl_buffer );

diff --git a/src/mesa/drivers/x11/xm_api.c b/src/mesa/drivers/x11/xm_api.c
index 6455889..b7c94aa 100644
--- a/src/mesa/drivers/x11/xm_api.c
+++ b/src/mesa/drivers/x11/xm_api.c
@@ -1193,7 +1193,6 @@ xmesa_check_and_update_buffer_size(XMesaContext 
xmctx, XMe
        struct gl_context *ctx = xmctx ? &xmctx->mesa : NULL;
        _mesa_resize_framebuffer(ctx, &(drawBuffer->mesa_buffer), width, 
height);
     }
-   drawBuffer->mesa_buffer.Initialized = GL_TRUE; /* XXX TEMPORARY? */
  }


With those fixes,
Reviewed-by: Brian Paul <brianp at vmware.com>