[Mesa-dev] [PATCH 2/2] draw: allow overflows in the llvm paths

Roland Scheidegger sroland at vmware.com
Tue Jun 25 06:12:28 PDT 2013


Am 25.06.2013 00:54, schrieb Zack Rusin:
> Because our code couldn't handle it we were skipping rendering
> if we detected overflows. According to the spec we should
> still render but with all 0 vertices, which is what the llvm
> code already does. So for the llvm paths lets enable processing
> even if an overflow condition has been detected.
> 
> Signed-off-by: Zack Rusin <zackr at vmware.com>
> ---
>  src/gallium/auxiliary/draw/draw_pt.c |   12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/src/gallium/auxiliary/draw/draw_pt.c b/src/gallium/auxiliary/draw/draw_pt.c
> index 720d7b1..e0b8007 100644
> --- a/src/gallium/auxiliary/draw/draw_pt.c
> +++ b/src/gallium/auxiliary/draw/draw_pt.c
> @@ -508,11 +508,15 @@ draw_vbo(struct draw_context *draw,
>                                       draw->pt.vertex_element,
>                                       draw->pt.nr_vertex_elements,
>                                       info);
> -
> -   if (index_limit == 0) {
> +#if HAVE_LLVM
> +   if (!draw->llvm)
> +#endif
> +   {
> +      if (index_limit == 0) {
>        /* one of the buffers is too small to do any valid drawing */
> -      debug_warning("draw: VBO too small to draw anything\n");
> -      return;
> +         debug_warning("draw: VBO too small to draw anything\n");
> +         return;
> +      }
>     }
>  
>     /* If we're collecting stats then make sure we start from scratch */
> 

For the series:
Reviewed-by: Roland Scheidegger <sroland at vmware.com>


More information about the mesa-dev mailing list