[Mesa-dev] [PATCH] xmlpool/build: Make sure to set mo properly

Matt Turner mattst88 at gmail.com
Tue Jun 25 18:57:46 PDT 2013


On Mon, Jun 24, 2013 at 1:53 AM,  <naota at elisp.net> wrote:
> Some shells dose not set variables sequentially in a statement i.e. "a=X
> b=${a}" won't set "b" to "X" but empty value.
>
> This patch introduce ";" to make sure "mo" is set properly before "lang"
> assignment.
>
> Cf. https://bugs.gentoo.org/show_bug.cgi?id=471302
> ---
>  src/mesa/drivers/dri/common/xmlpool/Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/common/xmlpool/Makefile.am b/src/mesa/drivers/dri/common/xmlpool/Makefile.am
> index b545f37..ad7887d 100644
> --- a/src/mesa/drivers/dri/common/xmlpool/Makefile.am
> +++ b/src/mesa/drivers/dri/common/xmlpool/Makefile.am
> @@ -66,7 +66,7 @@ options.h: t_options.h $(MOS)
>
>  # Update .mo files from the corresponding .po files.
>  %/LC_MESSAGES/options.mo: %.po
> -       @mo="$@" \
> +       @mo="$@"; \
>         lang=$${mo%%/*}; \
>         echo "Updating ($$lang) $@ from $?."; \
>         mkdir -p $$lang/LC_MESSAGES; \
> --
> 1.8.2.1

Thanks. I'll fix up a typo in the commit message and commit it.

Reviewed-by: Matt Turner <mattst88 at gmail.com>


More information about the mesa-dev mailing list