[Mesa-dev] [PATCH] ilo: Remove max_threads dead code path.

Vinson Lee vlee at freedesktop.org
Tue Jun 25 20:55:40 PDT 2013


max_threads cannot be greater than 28. It is either 21 or 28.

Fixes "Logically dead code" defect reported by Coverity.

Signed-off-by: Vinson Lee <vlee at freedesktop.org>
---
 src/gallium/drivers/ilo/ilo_gpe_gen6.c |    3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/gallium/drivers/ilo/ilo_gpe_gen6.c b/src/gallium/drivers/ilo/ilo_gpe_gen6.c
index 75721f1..ccc7edc 100644
--- a/src/gallium/drivers/ilo/ilo_gpe_gen6.c
+++ b/src/gallium/drivers/ilo/ilo_gpe_gen6.c
@@ -1307,9 +1307,6 @@ ilo_gpe_init_gs_cso_gen6(const struct ilo_dev_info *dev,
       max_threads = 21;
    }
 
-   if (max_threads > 28)
-      max_threads = 28;
-
    dw2 = GEN6_GS_SPF_MODE;
 
    dw4 = vue_read_len << GEN6_GS_URB_READ_LENGTH_SHIFT |
-- 
1.7.9.5



More information about the mesa-dev mailing list