[Mesa-dev] [PATCH] i965: Split surface format code into a new file (brw_surface_formats.c).
eric at anholt.net
Wed Jun 26 12:48:21 PDT 2013
Kenneth Graunke <kenneth at whitecape.org> writes:
> brw_wm_surface_state.c has gotten rather large and unwieldy. At this
> point, it consists of two separate portions:
> 1. Surface format code
> This includes the giant table of surface formats and what features
> they support on each generation, as well as the code to translate
> between Mesa formats and hardware formats.
> This is used across all generations.
> 2. Binding table (SURFACE_STATE) related code.
> This is the code to generate SURFACE_STATE entries for renderbuffers,
> textures, transform feedback buffers, constant buffers, and so on, as
> well as the code to assemble them into binding tables.
> This is only used on Gen4-6; gen7_surface_state.c has Gen7+ code.
> Since the two are logically separate, and one is reused on every
> generation while the other is not, it makes a lot of sense to split
> them out. It should also make finding code easier.
This makes a lot of sense to me.
Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 197 bytes
Desc: not available
More information about the mesa-dev