[Mesa-dev] [PATCH 1/4] mesa: move declarations before code

[Brian Paul]

On 06/26/2013 03:56 PM, Ian Romanick wrote:
> Patches 1 and 4 are
>
> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
>
> For patch 3, I share Jose's concern.  I would very much like to see this
> happen in directories containing code that will be built with MSVC.

Yeah, sounds good, but off-hand I have no idea how to do this per-directory.



> For patch 2, I think this is unnecessary if patch 3 is re-done.  Right?

Well, I was seeing a warning on a Ubuntu system from the code even 
without -Wdeclaration-after-statement and wanted to clean it up. 
Already pushed.

-Brian


>
> On 06/26/2013 12:50 PM, Brian Paul wrote:
>> ---
>>   src/mesa/program/register_allocate.c |    5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/mesa/program/register_allocate.c
>> b/src/mesa/program/register_allocate.c
>> index ea06a07..4eed0b5 100644
>> --- a/src/mesa/program/register_allocate.c
>> +++ b/src/mesa/program/register_allocate.c
>> @@ -630,9 +630,10 @@ ra_get_best_spill_node(struct ra_graph *g)
>>       * colored that we couldn't manage to color in ra_select().
>>       */
>>      for (i = g->stack_optimistic_start; i < g->stack_count; i++) {
>> +      float cost, benefit;
>> +
>>         n = g->stack[i];
>> -      float cost = g->nodes[n].spill_cost;
>> -      float benefit;
>> +      cost = g->nodes[n].spill_cost;
>>
>>         if (cost <= 0.0)
>>            continue;
>>