[Mesa-dev] [PATCH] os: add os_get_process_name() function

[Brian Paul]

On 06/27/2013 11:41 AM, Jose Fonseca wrote:
>
>
> ----- Original Message -----
>> ---
>>   src/gallium/auxiliary/Makefile.sources |    1 +
>>   src/gallium/auxiliary/os/os_process.c  |   86
>>   ++++++++++++++++++++++++++++++++
>>   src/gallium/auxiliary/os/os_process.h  |   40 +++++++++++++++
>>   3 files changed, 127 insertions(+)
>>   create mode 100644 src/gallium/auxiliary/os/os_process.c
>>   create mode 100644 src/gallium/auxiliary/os/os_process.h
>>
>> diff --git a/src/gallium/auxiliary/Makefile.sources
>> b/src/gallium/auxiliary/Makefile.sources
>> index 20ff5ba..c06f964 100644
>> --- a/src/gallium/auxiliary/Makefile.sources
>> +++ b/src/gallium/auxiliary/Makefile.sources
>> @@ -44,6 +44,7 @@ C_SOURCES := \
>>   	hud/hud_fps.c \
>>           hud/hud_driver_query.c \
>>   	os/os_misc.c \
>> +	os/os_process.c \
>>   	os/os_time.c \
>>   	pipebuffer/pb_buffer_fenced.c \
>>   	pipebuffer/pb_buffer_malloc.c \
>> diff --git a/src/gallium/auxiliary/os/os_process.c
>> b/src/gallium/auxiliary/os/os_process.c
>> new file mode 100644
>> index 0000000..fd9fc07
>> --- /dev/null
>> +++ b/src/gallium/auxiliary/os/os_process.c
>> @@ -0,0 +1,86 @@
>> +/**************************************************************************
>> + *
>> + * Copyright 2013 VMware, Inc.
>> + * All Rights Reserved.
>> + *
>> + * Permission is hereby granted, free of charge, to any person obtaining a
>> + * copy of this software and associated documentation files (the
>> + * "Software"), to deal in the Software without restriction, including
>> + * without limitation the rights to use, copy, modify, merge, publish,
>> + * distribute, sub license, and/or sell copies of the Software, and to
>> + * permit persons to whom the Software is furnished to do so, subject to
>> + * the following conditions:
>> + *
>> + * The above copyright notice and this permission notice (including the
>> + * next paragraph) shall be included in all copies or substantial portions
>> + * of the Software.
>> + *
>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
>> + * OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
>> + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT.
>> + * IN NO EVENT SHALL THE AUTHORS AND/OR ITS SUPPLIERS BE LIABLE FOR
>> + * ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
>> + * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
>> + * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
>> + *
>> + **************************************************************************/
>> +
>> +
>> +#include "pipe/p_config.h"
>> +#include "os/os_process.h"
>> +#include "util/u_memory.h"
>> +
>> +#if defined(PIPE_SUBSYSTEM_WINDOWS_USER)
>> +#  include <windows.h>
>> +#elif defined(__GLIBC__)
>> +#  include <errno.h>
>> +#else
>> +#  include <stdlib.h>
>> +#endif
>> +
>> +
>> +/**
>> + * Return the name of the current process.
>> + * \param procname  returns the process name
>> + * \param size  size of the procname buffer
>> + * \return  TRUE or FALSE for success, failure
>> + */
>> +boolean
>> +os_get_process_name(char *procname, size_t size)
>> +{
>> +   const char *name;
>> +#if defined(PIPE_SUBSYSTEM_WINDOWS_USER)
>> +   char szProcessPath[MAX_PATH];
>> +   char *lpProcessName;
>> +   char *lpProcessExt;
>> +
>> +   GetModuleFileNameA(NULL, szProcessPath, Elements(szProcessPath));
>> +
>> +   lpProcessName = strrchr(szProcessPath, '\\');
>> +   lpProcessName = lpProcessName ? lpProcessName + 1 : szProcessPath;
>> +
>> +   lpProcessExt = strrchr(lpProcessName, '.');
>> +   if (lpProcessExt) {
>> +      *lpProcessExt = '\0';
>> +   }
>> +
>> +   name = lpProcessName;
>> +
>
> This looks good.
>
> Do the ones below trim the directory too?

I only have info from google and the previously-posted r300 patch to go 
by, but yes, I think so.



> FWIW, apitrace also has a cross platform implementation of similar function, but uses slightly different methods for the non-Windows OS.
>
>> +#elif defined(__GLIBC__)
>> +   name = program_invocation_short_name;
>> +#else /* *BSD and OS X */
>> +   name = getprogname();
>
> There should be a #else here with a #warning/#error/ or return FALSE, just in case.

I'll add an explicit test for PIPE_OS_BSD || PIPE_OS_APPLE for the later 
case then an everything-else #warning.

-Brian