[Mesa-dev] [PATCH] i965: NULL check depth_mt to quiet static analysis.

Chad Versace chad.versace at linux.intel.com
Thu Jun 27 14:23:37 PDT 2013

On 06/27/2013 11:41 AM, Matt Turner wrote:
> ---
> I think (depth_irb == NULL) iff (depth_mt == NULL) and the same for
> stencil_irb and stencil_mt. I can understand how static analysis tools
> would miss this, since I haven't been able to prove it to myself
> either.

It sucks that we keep depth_mt and stencil_mt in global state separate
from the corresponding renderbuffers. But, each time I tried to remove
the global brw->depthstencil.{depth,stencil}_mt vars, I encountered
some problems in the disentanglement. Perhaps I didn't try hard enough.

Anyway, this makes static analysis happy and adds only epsilon additional cycles.
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>

More information about the mesa-dev mailing list