[Mesa-dev] [PATCH] build: fix out-of-tree builds in gallium/auxiliary

[Andreas Boll]

2013/6/28 Ross Burton <ross.burton at intel.com>

> The rules were writing files to e.g. util/u_indices_gen.py, but in an
> out-of-tree build this directory doesn't exist in the build directory.  So,
> create the directories just in case.
>
> Note: This patch is a candidate for the 9.0 and 9.1 branches.
>

I think you can drop 9.0, since gallium was converted to Automake in mesa
9.1.


>
> Signed-off-by: Ross Burton <ross.burton at intel.com>
> ---
>  src/gallium/auxiliary/Makefile.am |    4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/src/gallium/auxiliary/Makefile.am
> b/src/gallium/auxiliary/Makefile.am
> index f14279b..0c3e7ba 100644
> --- a/src/gallium/auxiliary/Makefile.am
> +++ b/src/gallium/auxiliary/Makefile.am
> @@ -38,13 +38,17 @@ libgallium_la_SOURCES += \
>  endif
>
>  indices/u_indices_gen.c: $(srcdir)/indices/u_indices_gen.py
> +       mkdir --parents indices
>

Please use the autoconf variable $(MKDIR_P) instead of mkdir --parents.

With these changes:
Reviewed-by: Andreas Boll <andreas.boll.dev at gmail.com>


>         $(AM_V_GEN) $(PYTHON2) $< > $@
>
>  indices/u_unfilled_gen.c: $(srcdir)/indices/u_unfilled_gen.py
> +       mkdir --parents indices
>         $(AM_V_GEN) $(PYTHON2) $< > $@
>
>  util/u_format_srgb.c: $(srcdir)/util/u_format_srgb.py
> +       mkdir --parents util
>         $(AM_V_GEN) $(PYTHON2) $< > $@
>
>  util/u_format_table.c: $(srcdir)/util/u_format_table.py
> $(srcdir)/util/u_format_pack.py $(srcdir)/util/u_format_parse.py
> $(srcdir)/util/u_format.csv
> +       mkdir --parents util
>         $(AM_V_GEN) $(PYTHON2) $(srcdir)/util/u_format_table.py
> $(srcdir)/util/u_format.csv > $@
> --
> 1.7.10.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130628/10f42451/attachment.html>