[Mesa-dev] [PATCH] llvmpipe: bump glsl version to 140

[Roland Scheidegger]

Am 01.03.2013 08:50, schrieb Andreas Boll:
> 2013/3/1  <sroland at vmware.com>:
>> From: Roland Scheidegger <sroland at vmware.com>
>>
>> texel offsets should have been the last missing feature (not sure
>> if anything is actually missing for 140). In any case we still
>> don't do OpenGL 3.0 (missing MSAA which will be difficult,
>> plus EXT_packed_float, ARB_depth_buffer_float and EXT_framebuffer_sRGB).
>>
>> v2: bump to 140 instead - we have everything except we crash when not writing
>> to gl_Position (but softpipe crashes as well) so let's just say this is a bug
>> instead. Also (by Dave Airlie's suggestion) update llvm-todo.txt.
>> ---
>>  src/gallium/docs/llvm-todo.txt           |   16 +++++-----------
>>  src/gallium/drivers/llvmpipe/lp_screen.c |    2 +-
>>  2 files changed, 6 insertions(+), 12 deletions(-)
>>
>> diff --git a/src/gallium/docs/llvm-todo.txt b/src/gallium/docs/llvm-todo.txt
>> index a5a8c1a..02b4b62 100644
>> --- a/src/gallium/docs/llvm-todo.txt
>> +++ b/src/gallium/docs/llvm-todo.txt
>> @@ -4,18 +4,12 @@ TODO covering gallivm/llvmpipe
>>  Goal: GL3.0 support in llvmpipe
>>  -------------------------------
>>
>> -TXQ opcode support - airlied WIP
>> -TXF opcode support.
>> -Integer texture fetch support
>> -Integer renderbuffer support
>> -Vertex ID support.
>> -EXT_transform_feedback support - airlied WIP
>> -clip distance support - airlied WIP
>> -vertex clip support - airlied WIP
>> -EXT_texture_array support - Jakob WIP
>> +EXT_packed_float support.
>> +ARB_depth_buffer_float support.
>> +EXT_framebuffer_sRGB support.
>> +MSAA support.
>> +
>>
>>  Goal: extension parity with softpipe:
>>  -------------------------------------
>> -GL3.0 support.
>> -EXT_timer_query - airlied posted a patch
>>
>> diff --git a/src/gallium/drivers/llvmpipe/lp_screen.c b/src/gallium/drivers/llvmpipe/lp_screen.c
>> index 05bbca5..aab13b3 100644
>> --- a/src/gallium/drivers/llvmpipe/lp_screen.c
>> +++ b/src/gallium/drivers/llvmpipe/lp_screen.c
>> @@ -195,7 +195,7 @@ llvmpipe_get_param(struct pipe_screen *screen, enum pipe_cap param)
>>     case PIPE_CAP_VERTEX_COLOR_CLAMPED:
>>        return 1;
>>     case PIPE_CAP_GLSL_FEATURE_LEVEL:
>> -      return 120;
>> +      return 130;
>                       ^^^
> I think you forgot to update this line in v2. Should be 140.
> 
>>     case PIPE_CAP_QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION:
>>        return 0;
>>     case PIPE_CAP_COMPUTE:

Yeah it got lost at some point. The commit message also was a bit odd...

Roland