[Mesa-dev] [PATCH 2/2] st/mesa: add switch case for ir_txf_ms to silence warning

[Dave Airlie]

On Sat, Mar 2, 2013 at 12:02 PM, Roland Scheidegger <sroland at vmware.com> wrote:
> Am 02.03.2013 01:36, schrieb Brian Paul:
>> ---
>>  src/mesa/state_tracker/st_glsl_to_tgsi.cpp |    3 +++
>>  1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
>> index 8e3e3b8..c41b583 100644
>> --- a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
>> +++ b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
>> @@ -2746,6 +2746,9 @@ glsl_to_tgsi_visitor::visit(ir_texture *ir)
>>        offset = this->result;
>>        }
>>        break;
>> +   case ir_txf_ms:
>> +      assert(!"Unexpected ir_txf_ms opcode");
>> +      break;
>>     }
>>
>>     if (ir->projector) {
>>
>
> Series looks good to me. I guess we need a new opcode like
> (TGSI_OPCODE_TXF_MS?), unless we switch everything over and only use the
> new sample style opcodes which already have that (SAMPLE_I_MS) :-).

I'm not really sure we do, from what I can see TXF is sufficent since
LOD is bogus with MS textures so you can reuse the slot. r600 hw at
least only has one LD instruction from what I can see.

I've already done a good bit of the state tracker for this, I just
need to get a driver I can run it on :-)
(gallium-texture-multisample branch in my repo)

Dave.