[Mesa-dev] [PATCH] st/mesa: bound the sampler count before calling into the driver.

Jose Fonseca jfonseca at vmware.com
Sat Mar 9 13:35:15 PST 2013



----- Original Message -----
> On Sat, Mar 9, 2013 at 12:30 PM, Jose Fonseca <jfonseca at vmware.com> wrote:
> > Looks a sensible thing to do.
> >
> > Reviewed-by: Jose Fonseca <jfonseca at vmware.com>
> >
> 
> Thanks for the review.
> 
> > Any insight how the caller can be fixed so that this doesn't happen?
> 
> It happens to me when draw stages add more samplers on top of the max
> samplers from the application.

I see. Maybe it would be safer if draw module just passed things through (and warn) on those circumstances.  Do real apps stress this, or just tests?

Another alternative would be for drivers that always depend on draw to advertise one less stage..

Jose


More information about the mesa-dev mailing list