[Mesa-dev] [PATCH] st/mesa: bound the sampler count before calling into the driver.

Marek Olšák maraeo at gmail.com
Sun Mar 10 13:19:27 PDT 2013


On Sat, Mar 9, 2013 at 9:43 PM, Stéphane Marchesin
<stephane.marchesin at gmail.com> wrote:
> On Sat, Mar 9, 2013 at 12:30 PM, Jose Fonseca <jfonseca at vmware.com> wrote:
>> Looks a sensible thing to do.
>>
>> Reviewed-by: Jose Fonseca <jfonseca at vmware.com>
>>
>
> Thanks for the review.
>
>> Any insight how the caller can be fixed so that this doesn't happen?
>
> It happens to me when draw stages add more samplers on top of the max
> samplers from the application.

A couple of things:

1) The GLSL compiler should reject shaders which use more textures
than the driver supports.

2) I think this patch won't help you with Draw. If you wanna fix Draw
so that it doesn't exceed the max texture count limit, search for
driver_set_sampler_views.

Marek


More information about the mesa-dev mailing list