[Mesa-dev] remove mfeatures.h, take two
brianp at vmware.com
Tue Mar 12 08:05:17 PDT 2013
On 03/11/2013 10:02 PM, Jordan Justen wrote:
> On Mon, Mar 11, 2013 at 5:28 PM, Brian Paul<brianp at vmware.com> wrote:
>> On Sat, Mar 2, 2013 at 7:29 AM, Brian Paul<brianp at vmware.com> wrote:
>>> I've respun my remove-mfeatures branch as remove-mfeatures-2. It's in my
>>> repo on freedesktop.org
>>> This removes the mfeatures.h file and the last of the #ifdef FEATURE_x
>>> from core Mesa.
>>> Note, however, that the scons/makefiles still define FEATURE_GL,
>>> FEATURE_ES1, FEATURE_ES2, etc. because that controls whether some source
>>> files are built and in some places (like egl-static/egl_st.c) we need to
>>> test those symbols to avoid calling non-existant functions.
>>> If a few people can test, that'd be great.
>> Ping. Can anyone test the updated remove-mfeatures-2 branch? Thanks.
> I tested this with i965. It built and did not have regressions with
> piglit quick-driver.tests.
> How much changed from v1? I gave a reviewed-by for the v1 series, so I
> wonder if you would be willing to add my r-b to commit message for the
> patches that are unchanged from v1?
> If a lot changed, do you think v2 should be posted to the list for
> further code review?
The branch is pretty much the same, except:
1. A few commits were merged together to avoid build breaks.
2. A few commits at the end of the original series which touched the
-DFEATURE_x stuff in configure.ac were dropped.
More information about the mesa-dev