[Mesa-dev] [PATCH] DRI2: don't advertise GLX_INTEL_swap_event if it can't

Rob Clark robdclark at gmail.com
Tue Mar 12 16:59:03 PDT 2013


On Tue, Mar 12, 2013 at 7:53 PM, Zack Rusin <zackr at vmware.com> wrote:
>> If ddx does not support swap, don't advertise it.  We might also be
>> able to get rid of the vmwgfx check (I'm not quite sure the purpose of
>> that check vs. just checking dri2Minor.
>
>
> No, not really. GLX_INTEL_swap_event doesn't have any hooks. You're checking for presence of generic swap extension.
>
> Also unfortunately dri2minor has no correlation to glx_intel_swap_event. There's no way to check for presence of GLX_INTEL_swap_event on this side.
>

well, from what I can tell, if you advertise this extension
applications will expect a swap event.  Which will never come if
dri/glx on client side remaps scheduleswap to copyregion.

So maybe there are other conditions where we should not advertise this
extension.  But if we know we will never get events, we should not
advertise this extension.

BR,
-R

>
> z


More information about the mesa-dev mailing list