[Mesa-dev] [PATCH 01/12] i965: Change fragment input related bitfields to 64-bit.
kenneth at whitecape.org
Tue Mar 12 22:23:48 PDT 2013
On 03/11/2013 03:51 PM, Paul Berry wrote:
> This patch updates the bitfields brw_context::wm.input_size_masks,
> tracker::size_masks, and brw_wm_prog_key::proj_attrib_mask, all of
> which are indexed by gl_frag_attrib, from 32-bit to 64-bit.
> This paves the way for supporting geometry shaders, and for merging
> the gl_frag_attrib and gl_vert_result enums. The combination of these
> two will require at least 55 bits in the bitfields.
> src/mesa/drivers/dri/i965/brw_context.h | 2 +-
> src/mesa/drivers/dri/i965/brw_fs.cpp | 7 ++++---
> src/mesa/drivers/dri/i965/brw_vs_constval.c | 18 +++++++++---------
> src/mesa/drivers/dri/i965/brw_wm.c | 2 +-
> src/mesa/drivers/dri/i965/brw_wm.h | 2 +-
> 5 files changed, 16 insertions(+), 15 deletions(-)
Your patch looks good. However, I hate this code, and so seeing your
patch inspired me to re-measure whether the optimization is actually
still worth doing. Turns out, it isn't: it actually makes performance
slightly -worse- in the game it was supposed to help.
So I've sent out a series to delete all this. Hopefully, if Eric
agrees, we can just throw it out and you can drop this patch.
Sorry for the trouble!
More information about the mesa-dev