[Mesa-dev] [PATCH 2/4] radeonsi: switch to using resource destribtors for constants

[Michel Dänzer]

On Don, 2013-03-14 at 16:49 +0100, Christian König wrote: 
> diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c
> index a395ec4..219add5 100644
> --- a/src/gallium/drivers/radeonsi/si_state.c
> +++ b/src/gallium/drivers/radeonsi/si_state.c
> [...]
> +	/* Fill in a T# buffer resource description */
> +	si_pm4_sh_data_add(pm4, va & 0xFFFFFFFF);

The masking is superfluous.


> +	si_pm4_sh_data_add(pm4, (S_008F04_BASE_ADDRESS_HI(va >> 32) |
> +				 S_008F04_STRIDE(0)));
> +	si_pm4_sh_data_add(pm4, 0xffffffff); //cb->buffer_size);

Why not use cb->buffer_size?


The rest of the radeonsi patches in this series looks good to me.


-- 
Earthling Michel Dänzer           |                   http://www.amd.com
Libre software enthusiast         |          Debian, X and DRI developer