[Mesa-dev] [PATCH 4/7] mesa: improve reported function name in Tex*Multisample

[Chris Forbes]

Now that there are 4 variants, just pass the function name into
teximagemultisample rather than reconstructing it.

Signed-off-by: Chris Forbes <chrisf at ijw.co.nz>
---
 src/mesa/main/teximage.c | 30 ++++++++++++++----------------
 1 file changed, 14 insertions(+), 16 deletions(-)

diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
index c499b90..815547d 100644
--- a/src/mesa/main/teximage.c
+++ b/src/mesa/main/teximage.c
@@ -4195,7 +4195,7 @@ static void
 teximagemultisample(GLuint dims, GLenum target, GLsizei samples,
                     GLint internalformat, GLsizei width, GLsizei height,
                     GLsizei depth, GLboolean fixedsamplelocations,
-                    GLboolean immutable)
+                    GLboolean immutable, const char *func)
 {
    struct gl_texture_object *texObj;
    struct gl_texture_image *texImage;
@@ -4207,12 +4207,12 @@ teximagemultisample(GLuint dims, GLenum target, GLsizei samples,
 
    if (!(ctx->Extensions.ARB_texture_multisample
       && _mesa_is_desktop_gl(ctx))) {
-      _mesa_error(ctx, GL_INVALID_OPERATION, "glTexImage%uDMultisample", dims);
+      _mesa_error(ctx, GL_INVALID_OPERATION, "%s(unsupported)", func);
       return;
    }
 
    if (!check_multisample_target(dims, target)) {
-      _mesa_error(ctx, GL_INVALID_ENUM, "glTexImage%uDMultisample(target)", dims);
+      _mesa_error(ctx, GL_INVALID_ENUM, "%s(target)", func);
       return;
    }
 
@@ -4222,16 +4222,15 @@ teximagemultisample(GLuint dims, GLenum target, GLsizei samples,
 
    if (!is_renderable_texture_format(ctx, internalformat)) {
       _mesa_error(ctx, GL_INVALID_OPERATION,
-            "glTexImage%uDMultisample(internalformat=%s)",
-            dims,
-            _mesa_lookup_enum_by_nr(internalformat));
+            "%s(internalformat=%s)",
+            func, _mesa_lookup_enum_by_nr(internalformat));
       return;
    }
 
    sample_count_error = _mesa_check_sample_count(ctx, target,
          internalformat, samples);
    if (sample_count_error != GL_NO_ERROR) {
-      _mesa_error(ctx, sample_count_error, "glTexImage%uDMultisample(samples)", dims);
+      _mesa_error(ctx, sample_count_error, "%s(samples)", func);
       return;
    }
 
@@ -4239,7 +4238,7 @@ teximagemultisample(GLuint dims, GLenum target, GLsizei samples,
    texImage = _mesa_get_tex_image(ctx, texObj, 0, 0);
 
    if (texImage == NULL) {
-      _mesa_error(ctx, GL_OUT_OF_MEMORY, "glTexImage%uDMultisample()", dims);
+      _mesa_error(ctx, GL_OUT_OF_MEMORY, "%s()", func);
       return;
    }
 
@@ -4269,20 +4268,19 @@ teximagemultisample(GLuint dims, GLenum target, GLsizei samples,
    else {
       if (!dimensionsOK) {
          _mesa_error(ctx, GL_INVALID_VALUE,
-               "glTexImage%uDMultisample(invalid width or height)", dims);
+               "%s(invalid width or height)", func);
          return;
       }
 
       if (!sizeOK) {
          _mesa_error(ctx, GL_OUT_OF_MEMORY,
-               "glTexImage%uDMultisample(texture too large)", dims);
+               "%s(texture too large)", func);
          return;
       }
 
       /* Check if texObj->Immutable is set */
       if (texObj->Immutable) {
-         _mesa_error(ctx, GL_INVALID_OPERATION, "glTexImage%uDMultisample(immutable)",
-                     dims);
+         _mesa_error(ctx, GL_INVALID_OPERATION, "%s(immutable)", func);
          return;
       }
 
@@ -4318,7 +4316,7 @@ _mesa_TexImage2DMultisample(GLenum target, GLsizei samples,
                             GLsizei height, GLboolean fixedsamplelocations)
 {
    teximagemultisample(2, target, samples, internalformat,
-         width, height, 1, fixedsamplelocations, GL_FALSE);
+         width, height, 1, fixedsamplelocations, GL_FALSE, "glTexImage2DMultisample");
 }
 
 void GLAPIENTRY
@@ -4328,7 +4326,7 @@ _mesa_TexImage3DMultisample(GLenum target, GLsizei samples,
                             GLboolean fixedsamplelocations)
 {
    teximagemultisample(3, target, samples, internalformat,
-         width, height, depth, fixedsamplelocations, GL_FALSE);
+         width, height, depth, fixedsamplelocations, GL_FALSE, "glTexImage3DMultisample");
 }
 
 
@@ -4338,7 +4336,7 @@ _mesa_TexStorage2DMultisample(GLenum target, GLsizei samples,
                               GLsizei height, GLboolean fixedsamplelocations)
 {
    teximagemultisample(2, target, samples, internalformat,
-         width, height, 1, fixedsamplelocations, GL_TRUE);
+         width, height, 1, fixedsamplelocations, GL_TRUE, "glTexStorage2DMultisample");
 }
 
 void GLAPIENTRY
@@ -4348,5 +4346,5 @@ _mesa_TexStorage3DMultisample(GLenum target, GLsizei samples,
                               GLboolean fixedsamplelocations)
 {
    teximagemultisample(3, target, samples, internalformat,
-         width, height, depth, fixedsamplelocations, GL_TRUE);
+         width, height, depth, fixedsamplelocations, GL_TRUE, "glTexStorage3DMultisample");
 }
-- 
1.8.2