[Mesa-dev] [PATCH 1/2] gallium/sw: allow for negative strides in some places

[Dave Airlie]

On Tue, Mar 19, 2013 at 8:54 PM, Jose Fonseca <jfonseca at vmware.com> wrote:
> I think this is fine in principle, but I believe it's better to be exhaustive now than to waste time debugging unsigned/signed stride mismatches later.
>
> Especially all src/gallium/auxiliary/util modules should be updated:
>
> - src/gallium/auxiliary/util/u_format_*
> - src/gallium/auxiliary/util/u_surface.*
>
> among others. Here is the full list:
>
> $ git grep -l '\<\(unsigned\(\s\+int\)\?\|uint\)\s\+\w\+\(stride\|pitch\)\>' src/gallium/auxiliary/util/
> src/gallium/auxiliary/util/u_format.c
> src/gallium/auxiliary/util/u_format.h
> src/gallium/auxiliary/util/u_format_etc.c
> src/gallium/auxiliary/util/u_format_etc.h
> src/gallium/auxiliary/util/u_format_latc.c
> src/gallium/auxiliary/util/u_format_latc.h
> src/gallium/auxiliary/util/u_format_other.c
> src/gallium/auxiliary/util/u_format_other.h
> src/gallium/auxiliary/util/u_format_pack.py
> src/gallium/auxiliary/util/u_format_rgtc.c
> src/gallium/auxiliary/util/u_format_rgtc.h
> src/gallium/auxiliary/util/u_format_s3tc.c
> src/gallium/auxiliary/util/u_format_s3tc.h
> src/gallium/auxiliary/util/u_format_yuv.c
> src/gallium/auxiliary/util/u_format_yuv.h
> src/gallium/auxiliary/util/u_format_zs.c
> src/gallium/auxiliary/util/u_format_zs.h
> src/gallium/auxiliary/util/u_resource.c
> src/gallium/auxiliary/util/u_surface.c
> src/gallium/auxiliary/util/u_surface.h
> src/gallium/auxiliary/util/u_texture.c
> src/gallium/auxiliary/util/u_texture.h
> src/gallium/auxiliary/util/u_tile.c
> src/gallium/auxiliary/util/u_tile.h
> src/gallium/auxiliary/util/u_transfer.c
> src/gallium/auxiliary/util/u_transfer.h

Yeah I started to look at some, the problems are things like a fair
few need code rewriting, I might see if I can force the front buffer
inverted to test.

However if as Michel suggested and I think ajax mentioned to me before
I can use the Y_INVERTED bits from texture from pixmap and make the
compositor do it it might be all good. I'll play around some more
tomorrow.

Dave.