[Mesa-dev] [PATCH 02/13] i965/fs: Remove creation of a MOV instruction that's never used.

[Kenneth Graunke]

On 03/20/2013 05:36 PM, Eric Anholt wrote:
> We weren't inserting it into the list, so it did nothing.  This line was
> replaced by the MOV/MUL block above.
>
> NOTE: This is a candidate for the 9.1 branch.
> ---
>   src/mesa/drivers/dri/i965/brw_fs.cpp |    1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp
> index 5a5bfeb..2fb8989 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
> @@ -253,7 +253,6 @@ fs_visitor::VARYING_PULL_CONSTANT_LOAD(fs_reg dst, fs_reg surf_index,
>         } else {
>            instructions.push_tail(MUL(mrf, offset, fs_reg(4)));
>         }
> -      inst = MOV(mrf, offset);
>         inst = new(mem_ctx) fs_inst(FS_OPCODE_VARYING_PULL_CONSTANT_LOAD,
>                                     dst, surf_index);
>         inst->header_present = header_present;

Patches 2-6 and 9 are:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

I'm still working on the rest of the series.