[Mesa-dev] [PATCH v2 00/15] GLSL 1.50 interface blocks support

[Kenneth Graunke]

On 03/18/2013 04:34 PM, Jordan Justen wrote:
> git://people.freedesktop.org/~jljusten/mesa interface-blocks-v2
>
> v2:
>   * 3 new patches added to series
>   * Add support for interface block instance arrays
>   * Add support for rejecting unmatched interface blocks
>     during the linking phase.
>   * Known issue: fails new piglit glsl-1.50 test:
>     execution/interface-blocks-same-uniform-varying-name.shader_test
>
> v1:
>   * Initial support for GLSL 1.50 interface block support
>   * Known issue: interface block arrays are not working
>   * Known issue: rejection of unmatched interface blocks
>                  is not working
>   * Piglit tests for known issues have been sent to piglit list
>
> Jordan Justen (15):
>    glsl: rename ast_uniform_block to ast_interface_block
>    glsl parser: rename uniform block to interface block

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

>    glsl: parse in/out types for interface blocks

Nak - please respin with Eric's feedback.

>    glsl parser: reject VS+in & FS+out interface blocks
>    glsl parser: on desktop GL require GLSL 150 for instance names

I provided minor feedback, but even as is these are okay:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

>    glsl parser: allow in & out for interface block members

Nak - same concern as Eric.

>    glsl parser: handle interface block member qualifier

Still in my queue to review.

>    glsl ast_to_hir: support in/out for interface blocks

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

>    glsl ir: add as_dereference_record

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

Just go ahead and push this one, it's trivial.

>    glsl linker: cross validate interface block types between stages
>    glsl linker: remove interface block instance names
>    glsl link_varyings: link interface blocks using the block name
>    glsl linker: support arrays of interface block instances
>    glsl linker: compare interface blocks during intrastage linking
>    glsl linker: compare interface blocks during interstage linking

Still in my queue to review.