[Mesa-dev] [PATCH] llvmpipe: Fix assertions with assignment instead of comparison.

[Roland Scheidegger]

Am 23.03.2013 20:29, schrieb Vinson Lee:
> Fixes assign instead of compare defects reported by Coverity.
> 
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>  src/gallium/drivers/llvmpipe/lp_state_fs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/gallium/drivers/llvmpipe/lp_state_fs.c b/src/gallium/drivers/llvmpipe/lp_state_fs.c
> index 953a5c1..b87e1a4 100644
> --- a/src/gallium/drivers/llvmpipe/lp_state_fs.c
> +++ b/src/gallium/drivers/llvmpipe/lp_state_fs.c
> @@ -1156,7 +1156,7 @@ convert_to_blend_type(struct gallivm_state *gallivm,
>         */
>        assert(src_type.width == 32);
>        assert(dst_type.floating);
> -      assert(dst_type.width = 32);
> +      assert(dst_type.width == 32);
>        assert(dst_type.length % 4 == 0);
>        for (i = 0; i < 4; i++) {
>           tmpsrc[i] = src[i];
> @@ -1300,7 +1300,7 @@ convert_from_blend_type(struct gallivm_state *gallivm,
>         * conversion/packing.
>         */
>        assert(src_type.floating);
> -      assert(src_type.width = 32);
> +      assert(src_type.width == 32);
>        assert(src_type.length % 4 == 0);
>        assert(dst_type.width == 32);
>        for (i = 0; i < num_srcs / 4; i++) {
> 

Oops indeed.

Reviewed-by: Roland Scheidegger <sroland at vmware.com>