[Mesa-dev] [PATCH] radeonsi: add cs tracing

[Jerome Glisse]

On Mon, Mar 25, 2013 at 12:17 PM, Michel Dänzer <michel at daenzer.net> wrote:
> On Mon, 2013-03-25 at 12:01 -0400, j.glisse at gmail.com wrote:
>> From: Jerome Glisse <jglisse at redhat.com>
>>
>> Same as on r600, trace cs execution by writting cs offset after each
>> states, this allow to pin point lockup inside command stream and
>> narrow down the scope of lockup investigation.
>>
>> Signed-off-by: Jerome Glisse <jglisse at redhat.com>
>
> [...]
>
>> diff --git a/src/gallium/drivers/radeonsi/r600_texture.c b/src/gallium/drivers/radeonsi/r600_texture.c
>> index 6cafc3d..3d074a3 100644
>> --- a/src/gallium/drivers/radeonsi/r600_texture.c
>> +++ b/src/gallium/drivers/radeonsi/r600_texture.c
>> @@ -550,7 +550,7 @@ struct pipe_resource *si_texture_create(struct pipe_screen *screen,
>>
>>       if (!(templ->flags & R600_RESOURCE_FLAG_TRANSFER) &&
>>           !(templ->bind & PIPE_BIND_SCANOUT)) {
>> -             array_mode = V_009910_ARRAY_2D_TILED_THIN1;
>> +             array_mode = V_009910_ARRAY_1D_TILED_THIN1;
>>       }
>>
>>       r = r600_init_surface(rscreen, &surface, templ, array_mode,
>
> What's this hunk doing in here? :)
>
> The rest looks good to me on a quick look.
>

Oops i did it on top of my 2d tiling stuff

Cheers,
Jerome