[Mesa-dev] [PATCH] freedreno: document debug flag

[Erik Faye-Lund]

On Mon, Mar 25, 2013 at 6:36 PM, Erik Faye-Lund <kusmabite at gmail.com> wrote:
> On Mon, Mar 25, 2013 at 6:25 PM, Erik Faye-Lund <kusmabite at gmail.com> wrote:
>> Signed-off-by: Erik Faye-Lund <kusmabite at gmail.com>
>> ---
>>
>> I just peeked into the freedreno code, and noticed that it had some
>> undocumented debug-code. Perhaps it could make sense to document it,
>> like this?
>>
>>  src/gallium/docs/source/debugging.rst | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/src/gallium/docs/source/debugging.rst b/src/gallium/docs/source/debugging.rst
>> index e081cbf..3257618 100644
>> --- a/src/gallium/docs/source/debugging.rst
>> +++ b/src/gallium/docs/source/debugging.rst
>> @@ -81,6 +81,10 @@ Debug :ref:`flags` for the llvmpipe driver.
>>
>>  Number of threads that the llvmpipe driver should use.
>>
>> +.. envvar:: FD_MESA_DEBUG <bool> (false)
>> +
>> +Output debug information for the freedreno driver.
>> +
>>
>
> OK, so it turns out I was a bit trigger-happy. This isn't a normal
> bool, it's a bitflag. So perhaps something like this instead?
>
> diff --git a/src/gallium/docs/source/debugging.rst
> b/src/gallium/docs/source/debugging.rst
> index 3257618..8658412 100644
> --- a/src/gallium/docs/source/debugging.rst
> +++ b/src/gallium/docs/source/debugging.rst
> @@ -81,9 +81,10 @@ Debug :ref:`flags` for the llvmpipe driver.
>
>  Number of threads that the llvmpipe driver should use.
>
> -.. envvar:: FD_MESA_DEBUG <bool> (false)
> +.. envvar:: FD_MESA_DEBUG <bitflag> (false)
>
> -Output debug information for the freedreno driver.
> +Output debug information for the freedreno driver. Bit #0 enables debug
> +prints, while bit #1 enables TGSI and ASM dumps.
>
>
>  .. _flags:

...and with Rob's recent commit, I guess it should be:

diff --git a/src/gallium/docs/source/debugging.rst b/src/gallium/docs/source/deb
index e081cbf..dc308e5 100644
--- a/src/gallium/docs/source/debugging.rst
+++ b/src/gallium/docs/source/debugging.rst
@@ -81,6 +81,10 @@ Debug :ref:`flags` for the llvmpipe driver.

 Number of threads that the llvmpipe driver should use.

+.. envvar:: FD_MESA_DEBUG <flags> (0x0)
+
+Debug :ref:`flags` for the freedreno driver.
+

 .. _flags: