[Mesa-dev] Discussion on GLX_LARGEST_PBUFFER attribute in glXCreatePbuffer

[Tomasz Lis]

Hello,

I've noticed the GLX_LARGEST_PBUFFER property is not implemented correctly
(it is, but only in Gallium). Specification:

http://www.opengl.org/sdk/docs/man2/xhtml/glXCreatePbuffer.xml

The value should be used to decrease buffer size when necessary, but also
stored so it can be retrieved by glXQueryDrawable().

Currently CreatePbuffer() from glx_pbuffer.c just calls XCreatePixmap()
without checking the property. Also, the CreateDRIDrawable() receives it in
a list of attributes, but does nothing with it.

Width and height parameters should be probably checked and corrected before
the XCreatePixmap() call. Passing original width and height and value of
the GLX_LARGEST_PBUFFER attribute to XCreatePixmap() would allow more
advanced size checking, but that would require changing XCreatePixmap()
definition.


The GLX_LARGEST_PBUFFER property isn't used very often, but it is a part of
GLX specification - so definitely can't be left without implementation.

What do you think about it?
Any thoughts about how this should be implemented?

I'm curious to hear your opinion,
Tomasz
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130326/7a259757/attachment.html>