[Mesa-dev] [PATCH 2/4] Add test to verify accuracy of multisample scaled blitting

Anuj Phogat anuj.phogat at gmail.com
Wed May 1 13:58:56 PDT 2013


Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
---
 tests/all.tests                                    |   6 +
 .../ext_framebuffer_multisample/CMakeLists.gl.txt  |   1 +
 .../ext_framebuffer_multisample/blit-scaled.cpp    | 178 +++++++++++++++++++++
 3 files changed, 185 insertions(+)
 create mode 100644 tests/spec/ext_framebuffer_multisample/blit-scaled.cpp

diff --git a/tests/all.tests b/tests/all.tests
index 0f2a1ef..09b67a2 100644
--- a/tests/all.tests
+++ b/tests/all.tests
@@ -1635,6 +1635,12 @@ for num_samples in MSAA_SAMPLE_COUNTS:
                                 test_name)
                         ext_framebuffer_multisample[test_name] = PlainExecTest(executable)
 
+for num_samples in MSAA_SAMPLE_COUNTS:
+        test_name = ' '.join(['blit-scaled', str(num_samples)])
+        executable = 'ext_framebuffer_multisample-{0} -auto'.format(
+                test_name)
+        ext_framebuffer_multisample[test_name] = PlainExecTest(executable)
+
 ext_framebuffer_object = Group()
 spec['EXT_framebuffer_object'] = ext_framebuffer_object
 add_fbo_stencil_tests(ext_framebuffer_object, 'GL_STENCIL_INDEX1')
diff --git a/tests/spec/ext_framebuffer_multisample/CMakeLists.gl.txt b/tests/spec/ext_framebuffer_multisample/CMakeLists.gl.txt
index 1542b92..8143497 100644
--- a/tests/spec/ext_framebuffer_multisample/CMakeLists.gl.txt
+++ b/tests/spec/ext_framebuffer_multisample/CMakeLists.gl.txt
@@ -23,6 +23,7 @@ piglit_add_executable (ext_framebuffer_multisample-alpha-to-one-single-sample-bu
 		       draw-buffers-common.cpp alpha-to-one-single-sample-buffer.cpp)
 piglit_add_executable (ext_framebuffer_multisample-bitmap common.cpp bitmap.cpp)
 piglit_add_executable (ext_framebuffer_multisample-blit-flipped common.cpp blit-flipped.cpp)
+piglit_add_executable (ext_framebuffer_multisample-blit-scaled common.cpp blit-scaled.cpp)
 piglit_add_executable (ext_framebuffer_multisample-blit-mismatched-samples common.cpp blit-mismatched-samples.cpp)
 piglit_add_executable (ext_framebuffer_multisample-blit-mismatched-sizes common.cpp blit-mismatched-sizes.cpp)
 piglit_add_executable (ext_framebuffer_multisample-blit-mismatched-formats common.cpp blit-mismatched-formats.cpp)
diff --git a/tests/spec/ext_framebuffer_multisample/blit-scaled.cpp b/tests/spec/ext_framebuffer_multisample/blit-scaled.cpp
new file mode 100644
index 0000000..31d1f14
--- /dev/null
+++ b/tests/spec/ext_framebuffer_multisample/blit-scaled.cpp
@@ -0,0 +1,178 @@
+/*
+ * Copyright © 2013 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+
+/** \file blit-scaled.cpp
+ *
+ * This test verifies the accuracy of scaled blitting from a multisampled
+ * buffer to a single-sampled buffer by comparing the output from following
+ * rendering scenarios:
+ * 1. multisample buffer to single sample buffer scaled blit using extension
+ *    EXT_multisample_framebuffer_blit_scaled extension.
+ * 2. multisample buffer to single sample buffer non-scaled blit followed
+ *    by a single sample buffer to single sample buffer scaled blit with
+ *    nearest filtering.
+ */
+
+#include "common.h"
+#include <unistd.h>
+
+const int pattern_width = 256; const int pattern_height = 256;
+const float w = pattern_width / 2; const float h = pattern_height / 2;
+int num_samples;
+
+PIGLIT_GL_TEST_CONFIG_BEGIN
+
+	config.supports_gl_compat_version = 10;
+
+	config.window_width = pattern_width*2;
+	config.window_height = pattern_height;
+	config.window_visual = PIGLIT_GL_VISUAL_DOUBLE | PIGLIT_GL_VISUAL_RGBA;
+
+PIGLIT_GL_TEST_CONFIG_END
+
+static Fbo multisampled_fbo, singlesampled_fbo;
+static TestPattern *test_pattern;
+static Test *test = NULL;
+
+static void
+print_usage_and_exit(char *prog_name)
+{
+	printf("Usage: %s <num_samples>\n", prog_name);
+	piglit_report_result(PIGLIT_FAIL);
+}
+
+void
+piglit_init(int argc, char **argv)
+{
+	if (argc != 2)
+		print_usage_and_exit(argv[0]);
+
+	/* 1st arg: num_samples */
+	char *endptr = NULL;
+	num_samples = strtol(argv[1], &endptr, 0);
+	if (endptr != argv[1] + strlen(argv[1]))
+		print_usage_and_exit(argv[0]);
+
+	piglit_require_gl_version(21);
+	piglit_require_extension("GL_ARB_vertex_array_object");
+	piglit_require_extension("GL_EXT_framebuffer_multisample_blit_scaled");
+
+	/* Skip the test if num_samples > GL_MAX_SAMPLES */
+	GLint max_samples;
+	glGetIntegerv(GL_MAX_SAMPLES, &max_samples);
+	if (num_samples == 0 || num_samples > max_samples)
+		piglit_report_result(PIGLIT_SKIP);
+
+	singlesampled_fbo.setup(FboConfig(0,
+					  2 * pattern_width,
+					  pattern_height));
+	FboConfig msConfig(num_samples, pattern_width, pattern_height);
+	msConfig.attach_texture = true;
+	multisampled_fbo.setup(msConfig);
+
+	test_pattern = new Triangles();
+	test_pattern->compile();
+
+	test = create_test(TEST_TYPE_COLOR, num_samples,
+                           false /*small*/,
+			   true /* combine_depth_stencil */,
+			   pattern_width, pattern_height,
+			   16 /* supersample_factor */);
+
+	if (!piglit_check_gl_error(GL_NO_ERROR)) {
+		piglit_report_result(PIGLIT_FAIL);
+	}
+}
+
+enum piglit_result
+piglit_display()
+{
+	GLfloat scale;
+	GLint samples;
+	bool pass = true, result = true;
+
+	/* Draw the test pattern into the framebuffer with multisample
+	 * texture attachment.
+	 */
+	glBindFramebuffer(GL_DRAW_FRAMEBUFFER, multisampled_fbo.handle);
+	glGetIntegerv(GL_SAMPLES, &samples);
+	glViewport(0, 0, w, h);
+	test_pattern->draw(TestPattern::no_projection);
+
+	printf("Left: multisample scaled blit using extension.\n"
+	       "Right: multisample scaled blit using shader program.\n");
+
+        for(scale = 0.1; scale < 2.1f; scale += 0.1) {
+		glBindFramebuffer(GL_DRAW_FRAMEBUFFER, piglit_winsys_fbo);
+		glClear(GL_COLOR_BUFFER_BIT);
+
+		/* Resolve the multisampled_fbo by blitting it into the single-sampled
+		 * buffer with out scaling.
+		 */
+//		printf("ms to ss non-scaled blit.\n");
+		glBindFramebuffer(GL_READ_FRAMEBUFFER, multisampled_fbo.handle);
+		glBindFramebuffer(GL_DRAW_FRAMEBUFFER, singlesampled_fbo.handle);
+		glClear(GL_COLOR_BUFFER_BIT);
+		glBlitFramebuffer(0, 0, w, h,
+				  0, 0, w, h,
+				  GL_COLOR_BUFFER_BIT, GL_NEAREST);
+
+		/* Blit the resulting image to the screen, scaling the image to
+		 * required size.
+		 */
+//		printf("ss scaled blit.\n");
+		glBindFramebuffer(GL_READ_FRAMEBUFFER, singlesampled_fbo.handle);
+		glBindFramebuffer(GL_DRAW_FRAMEBUFFER, singlesampled_fbo.handle);
+		glBlitFramebuffer(0, 0, w, h,
+				  pattern_width, 0, pattern_width + w * scale, h * scale,
+				  GL_COLOR_BUFFER_BIT, GL_NEAREST);
+
+		/* Do scaled resolve of multisampled_fbo toleft half of singlesampled_fbo */
+//		printf("ms to ss scaled blit using extension.\n");
+		glBindFramebuffer(GL_READ_FRAMEBUFFER, multisampled_fbo.handle);
+		glBindFramebuffer(GL_DRAW_FRAMEBUFFER, singlesampled_fbo.handle);
+		glEnable(GL_SCISSOR_TEST);
+		glScissor(0, 0, pattern_width, pattern_height);
+		glClear(GL_COLOR_BUFFER_BIT);
+		glDisable(GL_SCISSOR_TEST);
+		glBlitFramebuffer(0, 0, w, h,
+				  0, 0, w * scale, h * scale,
+				  GL_COLOR_BUFFER_BIT, GL_SCALED_RESOLVE_FASTEST_EXT);
+
+		pass = piglit_check_gl_error(GL_NO_ERROR) && pass;
+
+//		printf("ss non-scaled blit to window system framebuffer.\n");
+		glBindFramebuffer(GL_READ_FRAMEBUFFER, singlesampled_fbo.handle);
+		glBindFramebuffer(GL_DRAW_FRAMEBUFFER, piglit_winsys_fbo);
+		glBlitFramebuffer(0, 0, 2 * pattern_width, piglit_height,
+				  0, 0, 2 * pattern_width, piglit_height,
+				  GL_COLOR_BUFFER_BIT, GL_NEAREST);
+
+		result = test->measure_accuracy();
+		pass = result && pass;
+		piglit_present_results();
+		printf("scaling_factor = %f, result = %s\n\n",
+		       scale, result ? "pass" : "fail");
+	}
+	return pass ? PIGLIT_PASS : PIGLIT_FAIL;
+}
-- 
1.8.1.4



More information about the mesa-dev mailing list