[Mesa-dev] [PATCH 1/2] gallivm: allow negation of all integer types

Zack Rusin zackr at vmware.com
Thu May 2 09:16:06 PDT 2013


----- Original Message -----
> > I don't oppose either.  Integer signedness has always been too loose for us
> > to be pedantic about it here.
> > 
> 
> Ok. We should update tgsi docs to reflect that, however.
> Note that we already moved some opcodes (ok only one, uadd) to the
> signed section in infer_src_type() for exactly this reason but yes
> that's a hack too, might as well move it back then for consistency.

How about the attached patch. 

To be honest, from just looking at the code, I think that adding instructions that explicitly work on signed integers would be cleaner (i.e. add IMAD and IADD).

z
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-gallivm-allow-negation-of-all-integer-types.patch
Type: text/x-patch
Size: 2732 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130502/be74ec7e/attachment.bin>


More information about the mesa-dev mailing list