[Mesa-dev] [PATCH 12/12] glsl: Death to array dereferences of vectors!

Kenneth Graunke kenneth at whitecape.org
Wed May 8 07:54:47 PDT 2013


On 05/03/2013 04:07 PM, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
>
> Now that all the places that used to generate array derefeneces of
> vectors have been changed to generate either ir_binop_vector_extract or
> ir_triop_vector_insert (or both), remove all support for dealing with
> this deprecated construct.
>
> As an added safeguard, modify ir_validate to reject ir_dereference_array
> of a vector.
>
> v2: Convert tabs to spaces.  Suggested by Eric.
>
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> Reviewed-by: Eric Anholt <eric at anholt.net>

Cool, I'm done reviewing.  Patches 10-12 and anything I didn't 
explicitly have comments on are:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

This looks nicer.  Thanks for doing it, Ian!


More information about the mesa-dev mailing list